Skip to content

python3Packages.selenium: 4.27.1 -> 4.28.1#376880

Closed
DaGenix wants to merge 1 commit intoNixOS:masterfrom
DaGenix:selenium-4.28.1
Closed

python3Packages.selenium: 4.27.1 -> 4.28.1#376880
DaGenix wants to merge 1 commit intoNixOS:masterfrom
DaGenix:selenium-4.28.1

Conversation

@DaGenix
Copy link
Contributor

@DaGenix DaGenix commented Jan 26, 2025

Selenium 4.27.1 has a bug that breaks the branca package. Specifically, there is no init.py file in this directory: https://github.com/SeleniumHQ/selenium/tree/selenium-4.27.1-python/py/selenium/webdriver/common/fedcm

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. labels Jan 26, 2025
@nix-owners nix-owners bot requested a review from jraygauthier January 26, 2025 04:38
@DaGenix
Copy link
Contributor Author

DaGenix commented Jan 26, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376880


aarch64-darwin

⏩ 12 packages marked as broken and skipped:
  • python312Packages.roadtools
  • python312Packages.roadtools.dist
  • python312Packages.roadtx
  • python312Packages.roadtx.dist
  • python312Packages.selenium-wire
  • python312Packages.selenium-wire.dist
  • python313Packages.roadtools
  • python313Packages.roadtools.dist
  • python313Packages.roadtx
  • python313Packages.roadtx.dist
  • python313Packages.selenium-wire
  • python313Packages.selenium-wire.dist
❌ 63 packages failed to build:
  • bepasty
  • bepasty.dist
  • changedetection-io
  • changedetection-io.dist
  • python312Packages.diffenator2
  • python312Packages.diffenator2.dist
  • python312Packages.django-ckeditor
  • python312Packages.django-ckeditor.dist
  • python312Packages.folium
  • python312Packages.folium.dist
  • python312Packages.httpserver
  • python312Packages.httpserver.dist
  • python312Packages.hvplot
  • python312Packages.hvplot.dist
  • python312Packages.intake
  • python312Packages.intake.dist
  • python312Packages.jupyter-nbextensions-configurator
  • python312Packages.jupyter-nbextensions-configurator.dist
  • python312Packages.msticpy
  • python312Packages.msticpy.dist
  • python312Packages.notobuilder
  • python312Packages.notobuilder.dist
  • python312Packages.osmnx
  • python312Packages.osmnx.dist
  • python312Packages.pytest-selenium
  • python312Packages.pytest-selenium.dist
  • python312Packages.robotframework-selenium2library
  • python312Packages.robotframework-selenium2library.dist
  • python312Packages.robotframework-seleniumlibrary
  • python312Packages.robotframework-seleniumlibrary.dist
  • python312Packages.splinter
  • python312Packages.splinter.dist
  • python312Packages.undetected-chromedriver
  • python312Packages.undetected-chromedriver.dist
  • python313Packages.branca
  • python313Packages.branca.dist
  • python313Packages.diffenator2
  • python313Packages.diffenator2.dist
  • python313Packages.django-ckeditor
  • python313Packages.django-ckeditor.dist
  • python313Packages.httpserver
  • python313Packages.httpserver.dist
  • python313Packages.hvplot
  • python313Packages.hvplot.dist
  • python313Packages.intake
  • python313Packages.intake.dist
  • python313Packages.jupyter-nbextensions-configurator
  • python313Packages.jupyter-nbextensions-configurator.dist
  • python313Packages.notobuilder
  • python313Packages.notobuilder.dist
  • python313Packages.pytest-selenium
  • python313Packages.pytest-selenium.dist
  • python313Packages.robotframework-selenium2library
  • python313Packages.robotframework-selenium2library.dist
  • python313Packages.robotframework-seleniumlibrary
  • python313Packages.robotframework-seleniumlibrary.dist
  • python313Packages.selenium
  • python313Packages.selenium.dist
  • python313Packages.splinter
  • python313Packages.splinter.dist
  • python313Packages.undetected-chromedriver
  • python313Packages.undetected-chromedriver.dist
  • tests.devShellTools.nixos
✅ 4 packages built:
  • python312Packages.branca
  • python312Packages.branca.dist
  • python312Packages.selenium
  • python312Packages.selenium.dist

@DaGenix DaGenix mentioned this pull request Jan 26, 2025
13 tasks
Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Feb 1, 2025
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@wegank
Copy link
Member

wegank commented Apr 19, 2025

Done in dd74b44.

@wegank wegank closed this Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 2501-5000 This PR causes many rebuilds on Linux and should target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants