Skip to content

python3Packages.vcard: fix disabled specification#376430

Merged
NickCao merged 1 commit intoNixOS:masterfrom
ShamrockLee:vcard-disabled-fix
Jan 24, 2025
Merged

python3Packages.vcard: fix disabled specification#376430
NickCao merged 1 commit intoNixOS:masterfrom
ShamrockLee:vcard-disabled-fix

Conversation

@ShamrockLee
Copy link
Contributor

@ShamrockLee ShamrockLee commented Jan 24, 2025

vcard 0.16.1 supports Python 3.12.

See https://gitlab.com/engmark/vcard/-/blob/v0.16.1/setup.py?ref_type=tags

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 24, 2025
@ShamrockLee ShamrockLee changed the title vcard: fix disabled specification python3Packages.vcard: fix disabled specification Jan 24, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 24, 2025
@nix-owners nix-owners bot requested a review from l0b0 January 24, 2025 16:30
@ShamrockLee
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 376430


x86_64-linux

✅ 2 packages built:
  • python312Packages.vcard
  • python312Packages.vcard.dist

@l0b0
Copy link
Contributor

l0b0 commented Jan 24, 2025

Thank you, forgot to update this!

@NickCao NickCao merged commit a9a193d into NixOS:master Jan 24, 2025
50 of 52 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 24, 2025

Successfully created backport PR for release-24.11:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants