Merged
Conversation
Contributor
|
related / older attempt: #333467 |
24163d8 to
549fd9d
Compare
13 tasks
alyssais
requested changes
Jan 24, 2025
Member
There was a problem hiding this comment.
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Please vendor the patch, as it could disappear at any time following a rebase and GitHub garbage collection.
Contributor
Author
There was a problem hiding this comment.
makes sense, patch is now vendored
549fd9d to
0b901c5
Compare
0b901c5 to
096c222
Compare
alyssais
reviewed
Feb 9, 2025
| url = "https://git.kernel.org/pub/scm/utils/util-linux/util-linux.git/patch/?id=77454e58d58f904cfdc02d3ca5bb65f1bd8739fc"; | ||
| hash = "sha256-ELWC4bYN3rvn9XIN0XgCo55pXNfS2VpbZWuwzRLfO/0="; | ||
| }) | ||
| ./fix-darwin-build.patch |
Member
There was a problem hiding this comment.
Ideally there'd be a link to the PR so we know this has been submitted, but this has waited long enough so I'm just going to merge it.
alyssais
approved these changes
Feb 9, 2025
Contributor
|
Hey sweet thanks for merging this, if anyone needs help fixing pkgs breaks or something @ me here or woobilicious on matrix. I have some experience debugging root on bcachefs issues lol. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.