buildPython*: restructure in preparation for fixed-point argument support and overridePythonAttrs deprecation#375921
Conversation
22007a8 to
b2644e7
Compare
|
b2644e7 to
0c84104
Compare
6451a2d to
969fed9
Compare
969fed9 to
761d2df
Compare
|
I split the restructuring step into four commits for easier reviewing and merging. |
|
I split the miscelaneous changes before restructuring as a separate PR #378566. Let's merge it first. |
…alAttrs This commit is intentionally unformatted for smoother merging and rebasing experience.
This commit is intentionally unformatted for smoother merging and rebasing experience.
761d2df to
3678c2e
Compare
|
#378566 has been merged, and I have rebased this feature branch. |
philiptaron
left a comment
There was a problem hiding this comment.
After staring at it for a while and going through the commits one by one as suggested, this change makes sense to me and has no rebuilds.
|
@philiptaron Thank you for review and approval. As this PR might not be an easy merge into staging (due to the reformatting here and the |
This PR restructures the expression layout to prepare for implementing the fixed-point attribute support (#271387) and the transition from
overridePythonAttrstooverrideAttrs(#376372). #271387 depends on #271762, which might need additional discussion and consensus. This PR makes it easier to proceed with #376372 simultaneously.The only part of this PR that touches the programming logic is to use
drv.disabled(from<pkg>.passthru) instead ofattrs.disabled(from thebuildPython*arguments) to determine whether to throw the interpreter-unsupported error. This is necessary for transferring tolib.extendMkDerivation, astransformDrvmust be independent of the build-helper arguments.Please consider reviewing this PR commit-by-commit, as the total diff might not be intuitive to read after formatting.
How the layout changes
Before:
After this PR:
After adopting
lib.extendMkDerivation(#271387)Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.