llvmPackages.bolt: add experimental bolt hook#375435
llvmPackages.bolt: add experimental bolt hook#375435RossComputerGuy wants to merge 4 commits intoNixOS:stagingfrom
Conversation
1b7ad73 to
27d0f64
Compare
fd1b9b5 to
6554b12
Compare
0ba380f to
e1a994c
Compare
pkgs/top-level/stage.nix
Outdated
There was a problem hiding this comment.
Do we really need this? I'm not sure every possible thing you can set on a platform needs its own package set, and I especially don't think we need Hydra to build every single-change stdenv.
There was a problem hiding this comment.
We can drop it before merging but for the purposes of testing this PR, I added it in.
There was a problem hiding this comment.
I think this sort of thing is useful to have. For what it's worth. I don't think its existence needs to promise that it will work, much the same as for pkgsStatic and friends as well. It is quite powerful to have a simple name for this thing to reach for from the shell.
There was a problem hiding this comment.
The problem is that these things also make it way too easy to use them within Nixpkgs, and then we end up with a layering violation where a single package is going through a whole distinct package set out of convenience.
But that's a general problem that needs to be solved, by making these inaccessible from within Nixpkgs while still being a convenience layer on top, so if this is really useful it can stay. I think there's no justification for building this set on Hydra, though.
There was a problem hiding this comment.
The problem is that these things also make it way too easy to use them within Nixpkgs, and then we end up with a layering violation where a single package is going through a whole distinct package set out of convenience.
We can add in a config option similar to the aliases one which enables the subsets. Then have it disabled in Hydra / CI.
But that's a general problem that needs to be solved, by making these inaccessible from within Nixpkgs while still being a convenience layer on top, so if this is really useful it can stay. I think there's no justification for building this set on Hydra, though.
I kinda agree but its also good to ensure things work.
There was a problem hiding this comment.
The problem is that these things also make it way too easy to use them within Nixpkgs, and then we end up with a layering violation where a single package is going through a whole distinct package set out of convenience.
We can add in a config option similar to the aliases one which enables the subsets. Then have it disabled in Hydra / CI.
Oh that's not a bad idea!
There was a problem hiding this comment.
Unresolved this thread, because "We can drop it before merging" should still be taken care of eventually. (Or via the variants stuff, but not the current form)
There was a problem hiding this comment.
I thought it was resolved because it sounded like Alyssa agreed to the variants overlay.
There was a problem hiding this comment.
I still don't really like adding new ones, but not enough to really object if it can't be used within Nixpkgs.
e1a994c to
ee19a77
Compare
|
|
pkgs/top-level/stage.nix
Outdated
There was a problem hiding this comment.
Unresolved this thread, because "We can drop it before merging" should still be taken care of eventually. (Or via the variants stuff, but not the current form)
77def38 to
edbd735
Compare
edbd735 to
3013690
Compare
3013690 to
4d9313a
Compare
There was a problem hiding this comment.
Idk, I couldn't get the hook to appear for whatever reason.
There was a problem hiding this comment.
I wonder if there's a more precise verb than "use" that would work better here…
4d9313a to
573ad00
Compare
573ad00 to
ebe6bca
Compare
Things done
Experimental concept, this adds a hook which calls bolt on the installed binaries. The idea is this will optimize the installed binaries. We'll test with just
hellohowever all packages can be tried by enablinguseBoltwhen specifying the cross platform.nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.