nixosTests.postgresql.*: fix eval#375292
Merged
wolfgangwalther merged 1 commit intoNixOS:stagingfrom Jan 20, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: nixos
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Thanks for fixing!
We also need the same for some other tests in the same folder, which use the same pattern!
The `libpq` attribute from `postgresqlVersions` doesn't have a `pkgs` attribute with extensions in it. Filtering for postgresql server packages only fixes the problem. Reported in NixOS#359659 (comment)
Ma27
changed the title
github-actions
bot
added
10.rebuild-darwin: 0
wolfgangwalther
approved these changes
Jan 20, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
Didn't run, just eye-balled. LGTM.
We should think about extracting some of that logic into maybe a set of utility functions for those postgresql tests. But that's not for here, not for now.
wegank
added
the
12.approvals: 1
Merged
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
libpqattribute frompostgresqlVersionsdoesn't have apkgsattribute with extensions in it. Filtering for postgresql server packages only fixes the problem.Reported in #359659 (comment)
cc @trofi
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.