I have the impression that this CI will remove labels that does not match the yml file (example: #375210) 🤔 For example if you add the backport label to a random PR that only touches pkgs, as soon as the labeler CI triggers will it now remove the label?

For example if you add the backport label to a random PR that only touches pkgs, as soon as the labeler CI triggers will it now remove the label?

Right, very good catch. We use sync-labels: true for that. Going through the docs, I think the only option for us is to call the labeler action twice, once with sync-labels, once without - and store the configuration for both in different files.

If an additional action on each PR is needed then i'm in favor of just not doing it and closing this PR. Barely any PRs touch the CI setup, and the current action usage is already massive since eval was moved from ofborg.

I'm not saying we need a new job - it could be a second step in the same job. So almost no overhead. But the action itself needs to run twice.

We do forget to backport those changes to CI regularly, so I think this is a really good idea here.

and the current action usage is already massive since eval was moved from ofborg.

I have plans to save some of that by moving many of the simple checks (editorconfig, nixfmt, nixpkgs-vet, ... all those) into a single job. Imho that would both improve the output and save resources. Just didn't get to it, yet.

pushed the change, how may i test this on my branch?

how may i test this on my branch?

Since this uses pull_request_target, it will only trigger when it's on the main branch of a repo. So you'd need to:

• push this branch to the master branch of your fork
• create a PR in that fork to test it works

(it might also work if you just create a PR from another branch into this branch, without the master step. The PR needs to be in your fork. But I didn't test it that way, yet)

The ci runs on my own fork seem to get skipped for some reason...

tested working on my fork

Let's try this - we can always revert, if it causes problems.

I think this is now labeling the "backport: release-24.11" label to every PR now, I guess "!ci/OWNERS" is matching all of them now (since it is any-glob-to-any-file here).

🙈

Luckily it's the wrong label, so easy to fix that.

Will open a PR soon.