Closed
Conversation
Contributor
Author
|
FYI: @bjornfor |
github-actions
bot
added
10.rebuild-darwin: 101-500
bjornfor
reviewed
Jan 18, 2025
pkgs/by-name/th/thrift/package.nix
Outdated
Contributor
There was a problem hiding this comment.
Use the new "tag =" instead of "rev =" here?
bjornfor
reviewed
Jan 18, 2025
Contributor
bjornfor
left a comment
bjornfor
left a comment
There was a problem hiding this comment.
Patch LGTM, but would like to see the build result (revdeps) before merge. (Don't have time for that myself right now.)
Contributor
Author
|
Contributor
Author
|
@bjornfor I updated to use "tag" instead of "rev". I'm not 100% sure what you mean by the revdeps - do you mean posting the result of nixpkgs-review? If so, I ran |
Contributor
|
Yes, I meant nixpkgs-review. Can you try it again but set the option to do local eval? (It's in --help somewhere.) |
Contributor
|
Please squash the fixup commit. |
DaGenix
force-pushed
the
thrift-0.21.0
branch
from
09bbe2b to
05f7967
Compare
Contributor
Author
|
Contributor
Author
|
@bjornfor squashed. a ton of stuff failed to build. I will take a look at that. |
I'm fetching from Github instead of the apache server since the release from apache.org appears to be missing the file "lib/cpp/test/Thrift5272.thrift". As such, it will not build. For reasons that are unclear, the mirror on github appears to have that file and will build. I remove all the patches since it appears to build on aarch64-darwin without the patches. I removed the disabled tests since it appears to build on aarch64-darwin (sandbox = true) without those tests being disabled.
DaGenix
force-pushed
the
thrift-0.21.0
branch
from
05f7967 to
9e9d455
Compare
Contributor
Author
|
Contributor
Author
|
@bjornfor My original attempt to run nixpkgs-review appears to have failed, I think, because gnuradio didn't like being built in a sandbox on Mac OS. With the sandbox disabled, I got the above results. Still a bunch of failures, the few I've taken a look at don't appear to the thrift related. But, 157 packages is too much for me to look at one at a time. |
Contributor
Author
|
Some number of these failures I think result from clang 19 not being able to compile isa-l. I submitted a fix for clang 20 here: llvm/llvm-project#124427. I've also got these fixes in progress: #376876 and #376880. They don't seem related to thrift - but I think they will make the nixpkgs-review report look a little more tractable. |
Contributor
|
0.22 is now out. |
nixpkgs-ci
bot
added
the
2.status: merge conflict
This was referenced Sep 20, 2025
Merged
Contributor
|
#445433 has been merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm fetching from Github instead of the apache server since the release from apache.org appears to be missing the file
"lib/cpp/test/Thrift5272.thrift". As such, it will not build. For reasons that are unclear, the mirror on github appears to have that file and will build.
I remove all the patches since it appears to build on aarch64-darwin without the patches.
I removed the disabled tests since it appears to build on aarch64-darwin (sandbox = true) without those tests being disabled.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.