Skip to content

scipoptsuite: init at 9.2.1#374527

Merged
FliegendeWurst merged 7 commits intoNixOS:masterfrom
pmeinhold:adding-scipoptsuite
Mar 29, 2025
Merged

scipoptsuite: init at 9.2.1#374527
FliegendeWurst merged 7 commits intoNixOS:masterfrom
pmeinhold:adding-scipoptsuite

Conversation

@pmeinhold
Copy link
Contributor

@pmeinhold pmeinhold commented Jan 17, 2025 •
edited
Loading

Packaged all packages included in the SCIP Optimization Suite,
an open-source toolbox for generating and solving mixed integer nonlinear programs.

I did not create an actual scipoptsuite package, just its parts. (If the PR name is confusing.)

Including these packages gives computer scientists, applied mathematicians and enthusiasts quick and easy access to this actively developed optimization suite.

Renamed preexisting package soplex to scipopt-soplex to fit the SCIP Optimization Suite package names and added additional necessary build inputs to it.
Kept old soplex around for now.

Added packages:

  • scipopt-soplex
  • scipopt-scip
  • scipopt-zimpl
  • scipopt-papilo
  • scipopt-gcg
  • scipopt-ug

And I referenced myself as the maintainer.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • [ ] sandbox = relaxed
    • [ ] sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

@david-r-cox maybe you have opinions? :)

@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Jan 17, 2025
@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Jan 17, 2025
@pmeinhold pmeinhold force-pushed the adding-scipoptsuite branch from e024d84 to 1f82dcd Compare January 17, 2025 13:18
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 17, 2025
@pmeinhold pmeinhold changed the title Adding scipoptsuite scipoptsuite: init at 9.2.0 Jan 17, 2025
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
sikmir
sikmir reviewed Jan 18, 2025
View reviewed changes
@pmeinhold pmeinhold mentioned this pull request Feb 14, 2025
Closed
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 15, 2025
@pmeinhold pmeinhold changed the title scipoptsuite: init at 9.2.0 scipoptsuite: init at 9.2.1 Feb 18, 2025
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 18, 2025
@david-r-cox
Copy link
Member

david-r-cox commented Feb 20, 2025

I like the idea of adding these as a suite -- looks good to me!

@FliegendeWurst FliegendeWurst added the 8.has: package (new) This PR adds a new package label Mar 15, 2025
FliegendeWurst
FliegendeWurst reviewed Mar 15, 2025
View reviewed changes
FliegendeWurst
FliegendeWurst reviewed Mar 18, 2025
View reviewed changes
pkgs/by-name/sc/scipopt-ug/package.nix Outdated
Copy link
Member

@FliegendeWurst FliegendeWurst Mar 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wait, they only publish this tool as part of the release tarball? Do they explain why?

Copy link
Contributor Author

@pmeinhold pmeinhold Mar 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly, I don't know. Didn't ask (yet) and didn't find any explanation.

FliegendeWurst
FliegendeWurst reviewed Mar 24, 2025
View reviewed changes
@FliegendeWurst
Copy link
Member

FliegendeWurst commented Mar 24, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 374527

x86_64-linux

✅ 6 packages built:
  • scipopt-gcg
  • scipopt-papilo
  • scipopt-scip
  • scipopt-soplex
  • scipopt-ug
  • scipopt-zimpl

@FliegendeWurst
Copy link
Member

FliegendeWurst commented Mar 24, 2025

Looks pretty good.

Please squash commits for each package, to follow https://github.com/NixOS/nixpkgs/blob/master/pkgs/README.md#commit-conventions

@pmeinhold pmeinhold force-pushed the adding-scipoptsuite branch from 7e5f056 to 13964df Compare March 28, 2025 15:09
@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` and removed 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` labels Mar 28, 2025
@pmeinhold pmeinhold force-pushed the adding-scipoptsuite branch 2 times, most recently from 4af3602 to dcff3c0 Compare March 28, 2025 15:25
@pmeinhold pmeinhold force-pushed the adding-scipoptsuite branch from dcff3c0 to b014873 Compare March 28, 2025 15:28
@FliegendeWurst FliegendeWurst merged commit 5b4ac0f into NixOS:master Mar 29, 2025
27 of 29 checks passed
@flokli flokli mentioned this pull request Aug 22, 2025
Merged
13 tasks
@pmeinhold pmeinhold deleted the adding-scipoptsuite branch August 22, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sikmir sikmir sikmir left review comments

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees

No one assigned

Labels

8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pmeinhold @david-r-cox @FliegendeWurst @sikmir @wegank @NixOSInfra