Skip to content

digimend: Backport fix to enable building with Linux 6.12#373869

Closed
SohamG wants to merge 1 commit intoNixOS:masterfrom
SohamG:digimend-patch
Closed

digimend: Backport fix to enable building with Linux 6.12#373869
SohamG wants to merge 1 commit intoNixOS:masterfrom
SohamG:digimend-patch

Conversation

@SohamG
Copy link
Contributor

@SohamG SohamG commented Jan 14, 2025

This PR has landed in upstream, however a new release is yet to be made. Resolves #363873

Upstream PR: DIGImend/digimend-kernel-drivers#707

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@SohamG
Copy link
Contributor Author

SohamG commented Jan 14, 2025

CC @gebner

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Jan 14, 2025
@nix-owners nix-owners bot requested a review from gebner January 14, 2025 22:26
@SohamG
Copy link
Contributor Author

SohamG commented Jan 15, 2025

Please let me know how I can add this to nixos backports

@SohamG
Copy link
Contributor Author

SohamG commented Jan 28, 2025

Bump for visibility

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/5299

@PuercoPop
Copy link
Contributor

@SohamG The package is now unmaintained f887c1d 😿

For anyone else affected by this issue, now linux 6.11 being removed from the unstable branch pinning an old kernel is no longer a viable workaround. The current work around I'm using it to update digimend to the latest commit

  boot.kernelPackages = (pkgs.linuxPackagesFor pkgs.linux_latest).extend (
    final: prev: {
      digimend = prev.digimend.overrideAttrs (_attrs: {
        src = pkgs.fetchFromGitHub {
          owner = "digimend";
          repo = "digimend-kernel-drivers";
          rev = "f3c7c7f1179fc786a8e5aad027d4db904c31b42c";
          hash = "sha256-5kJj3SJfzrQ3n9r1YOn5xt0KO9WcEf0YpNMjiZEYMEo=";
        };
        # postInstall hook is not needed after
        # https://github.com/DIGImend/digimend-kernel-drivers/commit/3e41e856f38dc3ab3e2a81c2b6ee27e01a4aa245
        postInstall = "";
      });
    }
  );

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build failure: linuxKernel.packages.linux_6_12.digimend

3 participants