[backport staging-24.11] buildGoModule: fix GO_NO_VENDOR_CHECKS for v1.23+#373194
Merged
katexochen merged 1 commit intoNixOS:staging-24.11from Jan 13, 2025
Merged
Conversation
There was an additional check added for vendor/modules.txt when loading packages, see golang/go@38ee0c7#diff-61fb6e44eac25bd4d6a8a64b3f38ee8a41faaefd1ef481170a011ecfc0f7c76bR344 The new version of the patch tries to also disable these checks. Signed-off-by: Paul Meyer <[email protected]> (cherry picked from commit 75dfe81)
github-actions
bot
added
the
6.topic: golang
13 tasks
13 tasks
lafrenierejm
approved these changes
Jan 13, 2025
lafrenierejm
added
the
12.approvals: 1
kalbasit
approved these changes
Jan 13, 2025
lafrenierejm
added
12.approvals: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was an additional check added for vendor/modules.txt when loading packages, see
golang/go@38ee0c7#diff-61fb6e44eac25bd4d6a8a64b3f38ee8a41faaefd1ef481170a011ecfc0f7c76bR344 The new version of the patch tries to also disable these checks.
Signed-off-by: Paul Meyer [email protected]
(cherry picked from commit 75dfe81)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.