Skip to content

[Backport staging-24.11] treewide: handle *Phases variables __structuredAttrs-agnostically (round 2)#372688

Closed
nixpkgs-ci[bot] wants to merge 7 commits intostaging-24.11from
backport-352709-to-staging-24.11
Closed

[Backport staging-24.11] treewide: handle *Phases variables __structuredAttrs-agnostically (round 2)#372688
nixpkgs-ci[bot] wants to merge 7 commits intostaging-24.11from
backport-352709-to-staging-24.11

Conversation

@nixpkgs-ci
Copy link
Contributor

@nixpkgs-ci nixpkgs-ci bot commented Jan 10, 2025

Bot-based backport to staging-24.11, triggered by a label in #352709.

  • Before merging, ensure that this backport is acceptable for the release.
    • Even as a non-commiter, if you find that it is not acceptable, leave a comment.

@ShamrockLee
Copy link
Contributor

I'm backporting this to help future backports of executable-wrapping fixes based on __structuredAttrs = true; and uses wrapGAppsHook or wrapQtAppsHook.

@K900
Copy link
Contributor

K900 commented Jan 10, 2025

No, we should absolutely not do this.

@ShamrockLee
Copy link
Contributor

ShamrockLee commented Jan 10, 2025

Got it. Thank you for the feedback.

@emilazy emilazy deleted the backport-352709-to-staging-24.11 branch January 10, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: dotnet Language: .NET 6.topic: qt/kde Object-oriented framework for GUI creation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants