Skip to content

nixos/netbird: fix state directory mode#371315

Merged
drupol merged 1 commit intoNixOS:masterfrom
PatrickDaG:fix-netbird-secrets
Jan 6, 2025
Merged

nixos/netbird: fix state directory mode#371315
drupol merged 1 commit intoNixOS:masterfrom
PatrickDaG:fix-netbird-secrets

Conversation

@PatrickDaG
Copy link
Contributor

@PatrickDaG PatrickDaG commented Jan 6, 2025

fixes: #371286

Might be security critical since @mrshiposha is right this does expose the netbird secrets to anyone on the
same host.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Jan 6, 2025
@PatrickDaG PatrickDaG added 1.severity: security Issues which raise a security issue, or PRs that fix one backport release-24.11 labels Jan 6, 2025
@PatrickDaG PatrickDaG force-pushed the fix-netbird-secrets branch from 7f9889a to 8e44bd9 Compare January 6, 2025 01:14
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 6, 2025
@drupol drupol merged commit 942e79d into NixOS:master Jan 6, 2025
21 of 25 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 6, 2025

Successfully created backport PR for release-24.11:

@PatrickDaG PatrickDaG deleted the fix-netbird-secrets branch January 16, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.severity: security Issues which raise a security issue, or PRs that fix one 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

netbird: the final config files are world-readable (not from /nix/store)

2 participants