Skip to content

workflows/eval: add swapfile to tackle recent borderline OOM#371203

Merged
infinisil merged 1 commit intoNixOS:masterfrom
JohnRTitor:ci-eval-add-swap
Jan 5, 2025
Merged

workflows/eval: add swapfile to tackle recent borderline OOM#371203
infinisil merged 1 commit intoNixOS:masterfrom
JohnRTitor:ci-eval-add-swap

Conversation

@JohnRTitor
Copy link
Member

@JohnRTitor JohnRTitor commented Jan 5, 2025

Removed in #356023 (comment).

After some discussion on Matrix with @infinisil, we think its best to just add swapfile back.

Due to recent issues where eval failing due to out of memory #355847 (comment) #355847 (comment) #355847 (comment)

@JohnRTitor JohnRTitor requested review from Mic92 and infinisil January 5, 2025 17:56
@github-actions github-actions bot added 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Jan 5, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Jan 5, 2025
@JohnRTitor JohnRTitor changed the title workflows/eval: add swap to tackle recent borderline OOM workflows/eval: add swapfile to tackle recent borderline OOM Jan 5, 2025
@JohnRTitor
Copy link
Member Author

JohnRTitor commented Jan 5, 2025

@wolfgangwalther
Copy link
Contributor

Due to recent issues where eval failing due to out of memory #355847 (comment) #355847 (comment) #355847 (comment)

Note that 2 of the 3 links / comments are not really relevant OOM cases. One of them was not OOM at all and mine was a broken PR, causing huge memory usage, not related to the CI job.

@infinisil infinisil merged commit 7f9f600 into NixOS:master Jan 5, 2025
37 of 41 checks passed
@JohnRTitor JohnRTitor deleted the ci-eval-add-swap branch January 6, 2025 07:50
@wolfgangwalther
Copy link
Contributor

Backported in #370709.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants