Skip to content

python313Packages.gpgme: fix build#371188

Merged
dotlambda merged 1 commit intoNixOS:masterfrom
FliegendeWurst:gpgme-py313
Jan 6, 2025
Merged

python313Packages.gpgme: fix build#371188
dotlambda merged 1 commit intoNixOS:masterfrom
FliegendeWurst:gpgme-py313

Conversation

@FliegendeWurst
Copy link
Member

@FliegendeWurst FliegendeWurst commented Jan 5, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

@github-actions github-actions bot added the 6.topic: python Python is a high-level, general-purpose programming language. label Jan 5, 2025
@FliegendeWurst FliegendeWurst mentioned this pull request Jan 5, 2025
Merged
13 tasks
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. labels Jan 5, 2025
@nix-owners nix-owners bot requested a review from dotlambda January 5, 2025 17:16
SuperSandro2000
SuperSandro2000 approved these changes Jan 6, 2025
View reviewed changes
Copy link
Member

@SuperSandro2000 SuperSandro2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test but LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 6, 2025
dotlambda
dotlambda reviewed Jan 6, 2025
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch seems no longer necessary.

@FliegendeWurst
Copy link
Member Author

FliegendeWurst commented Jan 6, 2025

The patch seems no longer necessary.

The Python 3.13 package still requires it, I think? I get the error Please install the python development packages. without it.

@dotlambda dotlambda merged commit e4bf30f into NixOS:master Jan 6, 2025
22 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotlambda dotlambda dotlambda left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 101-500 This PR causes between 101 and 500 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@FliegendeWurst @dotlambda @SuperSandro2000 @wegank