ci/request-reviews: limit to 10 review requests#371115
Merged
infinisil merged 1 commit intoNixOS:masterfrom Jan 5, 2025
Merged
ci/request-reviews: limit to 10 review requests#371115infinisil merged 1 commit intoNixOS:masterfrom
infinisil merged 1 commit intoNixOS:masterfrom
Conversation
This mirrors ofborg for now.
github-actions
bot
added
the
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
mweinelt,
philiptaron and
risicle
wolfgangwalther
changed the title
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
|
Backport added in #370709, too. |
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This mirrors old ofborg for now and avoids pinging a huge number of reviewers, for example like in #370749 or even worse in #371100. The latter is similar to the old code-owners behavior after changing from master to staging. Both happened after #370857.
I'm thinking about alternatives based on my ideas in #366046 (comment), but to make those work well, we'd need to avoiding pinging maintainers in draft mode first as discussed in #370857 (comment). However, that's not trivial, because we don't want to run all of eval again on each "pull request edited" event.
This change here technically limits review requests to 10 reviewers max for code owners, too - not only maintainers. That's because both now used the same code path since #370857. I'm OK with this for now.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.