alsa-ucm-conf: fix hardcoded path to /bin/rm and /bin/mkdir#371100
Closed
drupol wants to merge 2 commits intoNixOS:stagingfrom
Closed
alsa-ucm-conf: fix hardcoded path to /bin/rm and /bin/mkdir#371100drupol wants to merge 2 commits intoNixOS:stagingfrom
/bin/rm and /bin/mkdir#371100drupol wants to merge 2 commits intoNixOS:stagingfrom
Conversation
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
github-actions
bot
added
10.rebuild-darwin: 1-10
Member
my guess would be no |
Contributor
Author
|
I just notice that this should go to |
drupol
force-pushed
the
push-ytnprzvyuluv
branch
from
66565a1 to
9613a91
Compare
github-actions
bot
added
6.topic: python
nix-owners
bot
requested review from
9999years,
NickCao,
OPNA2608,
RossComputerGuy,
SuperSandro2000,
amiloradovsky,
arcz,
athas,
c0bw3b,
jopejoe1,
kalekseev,
martinetd,
nagy,
nbp,
raehik,
sternenseemann,
stigtsp,
thoughtpolice,
ulysses4ever,
vcunat,
wentasah and
zakame
13 tasks
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fix #294170
Question: Should I add
coreutilstobuildInputs?Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.