Skip to content

[staging] treewide: remove obsolete aligned allocation workarounds#371054

Merged
NickCao merged 4 commits intoNixOS:stagingfrom
emilazy:push-vrpnwqpuwonq
Jan 5, 2025
Merged

[staging] treewide: remove obsolete aligned allocation workarounds#371054
NickCao merged 4 commits intoNixOS:stagingfrom
emilazy:push-vrpnwqpuwonq

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Jan 5, 2025

staging counterpart of #370749.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment labels Jan 5, 2025
Copy link
Contributor

@paparodeo paparodeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 5, 2025
Copy link
Member

@NickCao NickCao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM!

@NickCao NickCao merged commit 39b8894 into NixOS:staging Jan 5, 2025
22 of 26 checks passed
@emilazy emilazy deleted the push-vrpnwqpuwonq branch January 5, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: nodejs Node.js is a free, open-source, cross-platform JavaScript runtime environment 6.topic: python Python is a high-level, general-purpose programming language. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants