ci/request-reviews: lowercase handles consistently#370824
Merged
infinisil merged 1 commit intoNixOS:masterfrom Jan 4, 2025
Merged
ci/request-reviews: lowercase handles consistently#370824infinisil merged 1 commit intoNixOS:masterfrom
infinisil merged 1 commit intoNixOS:masterfrom
Conversation
This script assumed to get lowercased input before, but with the addition of pinging maintainers that's not necessarily true anymore. Since the checks for prAuthor and already-reviewed-by already lowercase, make sure to lowercase the handles in the users array, too.
github-actions
bot
added
the
6.topic: continuous integration
nix-owners
bot
requested review from
LeSuisse,
mweinelt,
philiptaron and
risicle
3 tasks
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
Author
Merged
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This script assumed to get lowercased input before, but with the addition of pinging maintainers that's not necessarily true anymore.
Since the checks for prAuthor and already-reviewed-by already lowercase, make sure to lowercase the handles in the users array, too.
Fixes #370456
Tested locally, but didn't run in CI, yet.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.