Skip to content

python313Packages.gevent: 24.2.1 -> 24.11.1#370782

Merged
FliegendeWurst merged 1 commit intoNixOS:stagingfrom
mweinelt:gevent-24.11.1
Jan 5, 2025
Merged

python313Packages.gevent: 24.2.1 -> 24.11.1#370782
FliegendeWurst merged 1 commit intoNixOS:stagingfrom
mweinelt:gevent-24.11.1

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 4, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 4, 2025
@nix-owners nix-owners bot requested a review from bjornfor January 4, 2025 03:05
bjornfor
bjornfor approved these changes Jan 4, 2025
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Not tested.

@wegank wegank added 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages. labels Jan 4, 2025
@dotlambda dotlambda mentioned this pull request Jan 4, 2025
Merged
13 tasks
FliegendeWurst
FliegendeWurst approved these changes Jan 5, 2025
View reviewed changes
Copy link
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes a test failure for python313Packages.geventhttpclient and probably more: gevent/gevent#2054

@FliegendeWurst FliegendeWurst merged commit e971c5a into NixOS:staging Jan 5, 2025
23 checks passed
@mweinelt mweinelt deleted the gevent-24.11.1 branch January 5, 2025 13:57
@mweinelt mweinelt mentioned this pull request Jan 10, 2025
Closed
@dotlambda dotlambda mentioned this pull request Jan 19, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bjornfor bjornfor bjornfor approved these changes

@FliegendeWurst FliegendeWurst FliegendeWurst approved these changes

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.approvals: 1 This PR was reviewed and approved by one person. 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in any of the changed packages.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mweinelt @bjornfor @FliegendeWurst @wegank