Skip to content

treewide: remove obsolete aligned allocation workarounds#370749

Merged
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-pvmxknvtrsrl
Jan 5, 2025
Merged

treewide: remove obsolete aligned allocation workarounds#370749
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-pvmxknvtrsrl

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Jan 3, 2025

The first deliverable of my ~100‐commit branch cleaning up obsolete Darwin stuff. Still needs building, and a staging PR for the change to Node.js.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy added the 6.topic: darwin Running or building packages on Darwin label Jan 3, 2025
@emilazy emilazy requested review from khaneliman and wegank January 3, 2025 23:26
@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. labels Jan 3, 2025
@emilazy emilazy force-pushed the push-pvmxknvtrsrl branch 2 times, most recently from 960a259 to b0341c2 Compare January 3, 2025 23:34
@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 3, 2025
@emilazy emilazy force-pushed the push-pvmxknvtrsrl branch from b0341c2 to 50fe44c Compare January 3, 2025 23:53
@github-actions github-actions bot added 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. and removed 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 4, 2025
@emilazy emilazy force-pushed the push-pvmxknvtrsrl branch from 50fe44c to 335751d Compare January 4, 2025 00:13
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. labels Jan 4, 2025
@emilazy emilazy force-pushed the push-pvmxknvtrsrl branch from 335751d to fc045af Compare January 4, 2025 00:27
@khaneliman
Copy link
Contributor

khaneliman commented Jan 4, 2025

LGTM overall, are you still searching for more occurrences or anything before marking it ready?

@emilazy
Copy link
Member Author

emilazy commented Jan 4, 2025

Waiting for nixpkgs-review to finish :)

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jan 4, 2025

A rebase to latest master should clear the Eval / Tag job after #370857. I'd be interested in seeing the result for it, which maintainers are requested and which of them is failing.

@emilazy
Copy link
Member Author

emilazy commented Jan 4, 2025

Will do, after I can get a nixpkgs-review through (it’s down to ~one remaining package but the community builder is overloaded right now).

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jan 4, 2025

it’s down to ~one remaining package but the community builder is overloaded right now

silently skips his own, not so important, builds on the community builder...

@emilazy
Copy link
Member Author

emilazy commented Jan 4, 2025

It’s the Darwin one FWIW, the Linux one is idle :)

@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jan 4, 2025

It’s the Darwin one FWIW, the Linux one is idle :)

Yeah, I only use the darwin one, too. I build Linux stuff on my own machine.

@emilazy emilazy force-pushed the push-pvmxknvtrsrl branch from fc045af to 205c169 Compare January 4, 2025 21:22
@nix-owners nix-owners bot requested review from ck3d, pSub, ratsclub, teutat3s and tobim January 4, 2025 21:31
@emilazy
Copy link
Member Author

emilazy commented Jan 4, 2025

@wolfgangwalther This showed up quite noisily on my open tab, though refreshing seems to coalesce it:

image

@wolfgangwalther wolfgangwalther mentioned this pull request Jan 4, 2025
Merged
1 task
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jan 4, 2025

This showed up quite noisily on my open tab, though refreshing seems to coalesce it:

Yeah, odd. I saw the same thing briefly. Odd, because I've never seen this with ofborg. But could be because we have been doing a lot more reviewer requests here (~30) at once than we ever did with ofborg, which was limited to 10. We should do something about that, discussed in #366046 (comment)

@emilazy
Copy link
Member Author

emilazy commented Jan 4, 2025

FWIW I always found the “pick a ~random subset of maintainers and ping them, drop all the rest” thing somewhat dubious. (But I don’t know if I have a better concrete proposal.)

@emilazy emilazy mentioned this pull request Jan 4, 2025
Merged
13 tasks
@khaneliman
Copy link
Contributor

khaneliman commented Jan 4, 2025 •
edited
Loading

@wolfgangwalther This showed up quite noisily on my open tab, though refreshing seems to coalesce it:

Yeah... doing it one by one will generate that way but then GitHub cleans it up later.

@emilazy emilazy mentioned this pull request Jan 5, 2025
Merged
13 tasks
@wolfgangwalther wolfgangwalther mentioned this pull request Jan 5, 2025
Merged
13 tasks
@emilazy emilazy marked this pull request as ready for review January 5, 2025 20:28
@emilazy
Copy link
Member Author

emilazy commented Jan 5, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370749

x86_64-darwin

⏩ 4 packages marked as broken and skipped:
  • cinny
  • cinny-desktop
  • cinny-unwrapped
  • sortmerna
❌ 20 packages failed to build:
  • hepmc3
  • herwig
  • ligo
  • mailpit
  • matrix-authentication-service
  • ns-3
  • p2pool
  • python312Packages.halide
  • python312Packages.hepmc3
  • rivet (python312Packages.rivet)
  • python313Packages.halide
  • python313Packages.hepmc3
  • python313Packages.rivet
  • root
  • sherpa
  • spades
  • thepeg
  • xfitter
  • yoda-with-root
  • zeek
✅ 47 packages built:
  • blockbook
  • blockstream-electrs
  • caf
  • chickenPackages_5.chickenEggs.rocksdb
  • conduwuit
  • electrs
  • fulcrum
  • grafana
  • halide
  • haskellPackages.rocksdb-haskell
  • haskellPackages.rocksdb-haskell-jprupp
  • haskellPackages.rocksdb-haskell-jprupp.doc
  • haskellPackages.rocksdb-haskell.doc
  • haskellPackages.rocksdb-query
  • haskellPackages.rocksdb-query.doc
  • lief
  • lief.py (python312Packages.lief ,python312Packages.lief.py)
  • luaformatter
  • matrix-conduit
  • mold
  • mold-wrapped
  • naja
  • naja.dev
  • naja.lib
  • polkadot
  • python312Packages.zeek (python312Packages.zeek.py)
  • python313Packages.lief (python313Packages.lief.py)
  • python313Packages.zeek (python313Packages.zeek.py)
  • qdrant
  • rocksdb
  • rocksdb.tools
  • rocksdb_6_23
  • rocksdb_6_23.tools
  • rocksdb_7_10
  • rocksdb_7_10.tools
  • rocksdb_8_11
  • rocksdb_8_11.tools
  • rocksdb_8_3
  • rocksdb_8_3.tools
  • solana-cli
  • sonic-server
  • stalwart-mail
  • surrealdb
  • trueseeing
  • trueseeing.dist
  • ueberzugpp
  • ytfzf

According to hydra-check, all of the failures are already present on master except for mailpit, which the community builder fails to build in the same way even on master, even with the sandbox off. Go figure.

@emilazy emilazy merged commit 5dbafd1 into NixOS:master Jan 5, 2025
24 of 28 checks passed
@emilazy emilazy deleted the push-pvmxknvtrsrl branch January 5, 2025 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@khaneliman khaneliman Awaiting requested review from khaneliman

@wegank wegank Awaiting requested review from wegank

@ratsclub ratsclub Awaiting requested review from ratsclub

@teutat3s teutat3s Awaiting requested review from teutat3s

@pSub pSub Awaiting requested review from pSub

@tobim tobim Awaiting requested review from tobim

@ck3d ck3d Awaiting requested review from ck3d

@Lassulus Lassulus Awaiting requested review from Lassulus

@guitargeek guitargeek Awaiting requested review from guitargeek

@fpletz fpletz Awaiting requested review from fpletz

@paveloom paveloom Awaiting requested review from paveloom

@stephank stephank Awaiting requested review from stephank

@Ma27 Ma27 Awaiting requested review from Ma27

@eljamm eljamm Awaiting requested review from eljamm

@GenericNerdyUsername GenericNerdyUsername Awaiting requested review from GenericNerdyUsername

@wahjava wahjava Awaiting requested review from wahjava

@offlinehacker offlinehacker Awaiting requested review from offlinehacker

@bzizou bzizou Awaiting requested review from bzizou

@figsoda figsoda Awaiting requested review from figsoda

@veprbl veprbl Awaiting requested review from veprbl

@globin globin Awaiting requested review from globin

@Frostman Frostman Awaiting requested review from Frostman

@twesterhout twesterhout Awaiting requested review from twesterhout

@WilliButz WilliButz Awaiting requested review from WilliButz

@adevress adevress Awaiting requested review from adevress

@fricklerhandwerk fricklerhandwerk Awaiting requested review from fricklerhandwerk

@anthonyroussel anthonyroussel Awaiting requested review from anthonyroussel

@azahi azahi Awaiting requested review from azahi

@AtilaSaraiva AtilaSaraiva Awaiting requested review from AtilaSaraiva

@Aleksanaa Aleksanaa Awaiting requested review from Aleksanaa

@dit7ya dit7ya Awaiting requested review from dit7ya

@wolfgangwalther wolfgangwalther Awaiting requested review from wolfgangwalther

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ulrikstrid ulrikstrid Awaiting requested review from ulrikstrid

Assignees

No one assigned

Labels

6.topic: darwin Running or building packages on Darwin 6.topic: ocaml OCaml is a general-purpose, high-level, multi-paradigm programming language. 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@emilazy @khaneliman @wolfgangwalther