Skip to content

python313Packages.watchdog: 5.0.3 -> 6.0.0#370643

Merged
mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt:watchdog-6.0.0
Jan 5, 2025
Merged

python313Packages.watchdog: 5.0.3 -> 6.0.0#370643
mweinelt merged 1 commit intoNixOS:stagingfrom
mweinelt:watchdog-6.0.0

Conversation

@mweinelt
Copy link
Member

@mweinelt mweinelt commented Jan 3, 2025 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 3, 2025
@mweinelt mweinelt merged commit ad25a6e into NixOS:staging Jan 5, 2025
37 of 41 checks passed
@mweinelt mweinelt deleted the watchdog-6.0.0 branch January 5, 2025 14:50
@mastoca
Copy link
Contributor

mastoca commented Feb 1, 2025

I'm getting a build error likely after this update. it looks like test_inotify_c.py needs to be added to the
disabledTestPaths? I'm not sure though.

error: builder for '/nix/store/ympm65fag91r3dh5zqgzfq4wllzlhaja-python3.12-watchdog-6.0.0.drv' failed with exit code 1;
       last 25 log lines:
       >
       > test_auto_restart_subprocess_termination[True] passed 1 out of the required 1 times. Success!
       > test_auto_restart_subprocess_termination[False] passed 1 out of the required 1 times. Success!
       > test_delayed_get passed 1 out of the required 1 times. Success!
       > test_nondelayed_get passed 1 out of the required 1 times. Success!
       > test_create passed 1 out of the required 1 times. Success!
       > test_delete passed 1 out of the required 1 times. Success!
       > test_modify passed 1 out of the required 1 times. Success!
       > test_chmod passed 1 out of the required 1 times. Success!
       > test_move passed 1 out of the required 1 times. Success!
       > test_case_change passed 1 out of the required 1 times. Success!
       > test_move_to passed 1 out of the required 1 times. Success!
       > test_move_from passed 1 out of the required 1 times. Success!
       > test_separate_consecutive_moves passed 1 out of the required 1 times. Success!
       > test_delete_self passed 1 out of the required 1 times. Success!
       > test_passing_unicode_should_give_unicode passed 1 out of the required 1 times. Success!
       > test_recursive_on passed 1 out of the required 1 times. Success!
       > test_recursive_off passed 1 out of the required 1 times. Success!
       > test_renaming_top_level_directory passed 1 out of the required 1 times. Success!
       > test_file_lifecyle passed 1 out of the required 1 times. Success!
       >
       > ===End Flaky Test Report===
       > =========================== short test summary info ============================
       > FAILED tests/test_inotify_c.py::test_select_fd - OSError: [Errno 24] Too many open files: '/build/pytest-of-nixbld/pytest-0/test_select_fd0/new_file'
       > ====== 1 failed, 162 passed, 3 skipped, 3 deselected in 61.21s (0:01:01) =======

@mweinelt
Copy link
Member Author

mweinelt commented Feb 1, 2025

Builds fine on hydra. Are you using a single-user nix setup or builindg as root?

@mastoca
Copy link
Contributor

mastoca commented Feb 1, 2025

it resolved itself, likely due to low disk on zfs caused the build to get wonky. Apologies for noise.

@Petingoso
Copy link
Contributor

Petingoso commented Oct 10, 2025

necro bump for posterity. My machine had only 1024 file descriptors available, temporarily upping them via ulimit fixed the build.

@mweinelt
Copy link
Member Author

mweinelt commented Oct 10, 2025 •
edited
Loading

Don't run nix in single user mode. Export NIX_REMOTE=daemon to pass them through the daemon that commonly has a higher ulimit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

6.topic: python Python is a high-level, general-purpose programming language. 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mweinelt @mastoca @Petingoso