Can we just do a treewide to remove all apple-sdk_11s and darwinMinVersionHooks ≤ 11.3? (No worries if you don’t feel like it, but it was on my to‐do list, so if you’re already doing this then maybe we can just knock it all out in one go. It’s not as big a job as it sounds like since a lot of the long tail of packages are still on the old pattern; those I can check my old branch for later.)

Can we just do a treewide to remove all apple-sdk_11s and darwinMinVersionHooks ≤ 11.3? (No worries if you don’t feel like it, but it was on my to‐do list, so if you’re already doing this then maybe we can just knock it all out in one go. It’s not as big a job as it sounds like since a lot of the long tail of packages are still on the old pattern; those I can check my old branch for later.)

I can try doing that, if you'd like.

If you feel up to it, it would be great :)

wait -- can this be merged tho -- I looked over the 100 files.

@emilazy Guessing this will have to go to staging.

wait -- can this be merged tho -- I looked over the 100 files.

I was wondering if it had to go to staging with how many are affected now.

The PR's base branch is set to staging, but 20 commits from the master branch are included. Make sure you know the right base branch for your changes, then:

• If the changes should go to the master branch, change the base branch to master
• If the changes should go to the staging branch, rebase your PR onto the merge base with the staging branch:

  # git rebase --onto $(git merge-base upstream/staging HEAD) $(git merge-base upstream/master HEAD)
  git rebase --onto 89019580b73ddd7d4b05fa5f6952a4676538c031 771c7e608ec7551137b2d239355ccf5856c4f0e7
  git push --force-with-lease

I guess there’s no PR for the staging-only ones yet? (I had assumed it was just split entirely into master‐targeting PRs, which seemed wrong.)

I guess there’s no PR for the staging-only ones yet? (I had assumed it was just split entirely into master‐targeting PRs, which seemed wrong.)

Sorry, just waiting for the other merges before ripping them out of here. I suppose I don't have to. But, I was just double checking rebuild count on the packages left. Although, according to @paparodeo I might be able to include some more straight to master.

FWIW the Facebook libraries (folly, edencommon, etc.) are only huge rebuilds on Linux, which this PR shouldn’t rebuild. So I think a lot of this can still go straight to master – presumably everything except the changes in #370445 (comment).

FWIW the Facebook libraries (folly, edencommon, etc.) are only huge rebuilds on Linux, which this PR shouldn’t rebuild. So I think a lot of this can still go straight to master – presumably everything except the changes in #370445 (comment).

Yeah, I didn't think they should rebuild either... just saw a lot of stuff getting flagged in my nixpkgs-review locally and was being cautious. Running it again looks like it was listing them as just affected but not actual needing rebuild. So I think we are good.

Probably Mic92/nixpkgs-review#446.