eval/tag: remove pull request author from reviewer list#370186
Closed
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Closed
eval/tag: remove pull request author from reviewer list#370186Mic92 wants to merge 1 commit intoNixOS:masterfrom
Mic92 wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: policy discussion
1 task
nix-owners
bot
requested review from
LeSuisse,
azuwis,
mweinelt,
risicle and
zowoq
7 tasks
github-actions
bot
added
10.rebuild-darwin: 0
wolfgangwalther
approved these changes
Jan 2, 2025
Contributor
wolfgangwalther
left a comment
wolfgangwalther
left a comment
There was a problem hiding this comment.
I ran the full jq (maintainers -> reviewers) command locally. Works.
Assuming that ${{ github.event.pull_request.user.login }} returns the correct value, which it should according to research, this should work in CI as well.
LGTM!
| jq -r 'keys[]' comparison/maintainers.json \ | ||
| | while read -r id; do gh api /user/"$id"; done \ | ||
| | jq -s '{ reviewers: map(.login) }' \ | ||
| | jq -s --arg author "${{ github.event.pull_request.user.login }}" '{ reviewers: map(.login) | map(select(. != $author)) }' \ |
Contributor
There was a problem hiding this comment.
Can be simplified:
Suggested change
| | jq -s --arg author "${{ github.event.pull_request.user.login }}" '{ reviewers: map(.login) | map(select(. != $author)) }' \ | |
| | jq -s --arg author "${{ github.event.pull_request.user.login }}" '{ reviewers: map(.login | select(. != $author)) }' \ |
13 tasks
3 tasks
Member
|
More complete fix: #370456 |
Contributor
|
Superseded by #370456. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things done
Untested
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.