thttpd: fix build with GCC >= 14#370071
Merged
FliegendeWurst merged 1 commit intoNixOS:masterfrom Mar 9, 2025
Merged
Conversation
Unfortunately there is no way in the configure script to persist CFLAGS from configure to the final build (CFLAGS is respected by configure, but by configure only). This roughly matches what alpine is doing now: They pass -fpermissive to configure via CFLAGS to avoid -Wimplicit-int, the -Wimplicit-function-declaration in the actual build seemingly never happens on Alpine, probably due to musl.
github-actions
bot
added
10.rebuild-darwin: 0
Contributor
|
28 tasks
tvlbot
pushed a commit
to tvlfyi/kit
that referenced
this pull request
Apr 20, 2025
- //3p/overlays/tvl:
- Drop upstreamed thttpd override.
NixOS/nixpkgs#370071
- Update telega.el and pin tdlib to compatible version.
- Some packages were affected by the change from fetchCargoTarball to
fetchCargoVendor which invalidates all cargoSha256 hashes without
explaining this to the user in any way. See
<NixOS/nixpkgs#394012>.
- //users/emery/pkgs/syndicate-server: can be removed anyways
- //third_party/nixpkgs:grpc-health-check: override is unnecessary now
- //third_party/nixpkgs:harmonia: updated cargoSha256
- //tvix: address some new clippy lints
- //tvix/cli: Reflect combined graphical iso change.
http://github.com/nixos/nixpkgs/commit/a2636dae467e16b48
- //tvix/*-go: rerun protoc on protobuf definitions
- //users/aspen/system/yeren:
Use default kernel version from nixpkgs as 6.11 is EOL.
This means DIGImend is no longer supported. Hopefully whatever tablet
aspen is using is supported by upstream now. See also
- https://spbnick.github.io/2024/11/03/Letting-go-of-DIGImend.html
- NixOS/nixpkgs#363873
- NixOS/nixpkgs#396730
- NixOS/nixpkgs#378830
Change-Id: If8be8b336fc6d8652ecab087decc6fbbc0509647
Reviewed-on: https://cl.tvl.fyi/c/depot/+/13276
Autosubmit: sterni <[email protected]>
Reviewed-by: emery <[email protected]>
Reviewed-by: tazjin <[email protected]>
Reviewed-by: aspen <[email protected]>
Tested-by: BuildkiteCI
tvlbot
pushed a commit
to tvlfyi/tvix
that referenced
this pull request
Apr 20, 2025
- //3p/overlays/tvl:
- Drop upstreamed thttpd override.
NixOS/nixpkgs#370071
- Update telega.el and pin tdlib to compatible version.
- Some packages were affected by the change from fetchCargoTarball to
fetchCargoVendor which invalidates all cargoSha256 hashes without
explaining this to the user in any way. See
<NixOS/nixpkgs#394012>.
- //users/emery/pkgs/syndicate-server: can be removed anyways
- //third_party/nixpkgs:grpc-health-check: override is unnecessary now
- //third_party/nixpkgs:harmonia: updated cargoSha256
- //tvix: address some new clippy lints
- //tvix/cli: Reflect combined graphical iso change.
http://github.com/nixos/nixpkgs/commit/a2636dae467e16b48
- //tvix/*-go: rerun protoc on protobuf definitions
- //users/aspen/system/yeren:
Use default kernel version from nixpkgs as 6.11 is EOL.
This means DIGImend is no longer supported. Hopefully whatever tablet
aspen is using is supported by upstream now. See also
- https://spbnick.github.io/2024/11/03/Letting-go-of-DIGImend.html
- NixOS/nixpkgs#363873
- NixOS/nixpkgs#396730
- NixOS/nixpkgs#378830
Change-Id: If8be8b336fc6d8652ecab087decc6fbbc0509647
Reviewed-on: https://cl.tvl.fyi/c/depot/+/13276
Autosubmit: sterni <[email protected]>
Reviewed-by: emery <[email protected]>
Reviewed-by: tazjin <[email protected]>
Reviewed-by: aspen <[email protected]>
Tested-by: BuildkiteCI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately there is no way in the configure script to persist CFLAGS from configure to the final build (CFLAGS is respected by configure, but by configure only). This roughly matches what alpine is doing now: They pass -fpermissive to configure via CFLAGS to avoid -Wimplicit-int, the -Wimplicit-function-declaration in the actual build seemingly never happens on Alpine, probably due to musl.
ref. #356812
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.