Skip to content

emacs30.pkgs.aio: Fix build#370021

Merged
jian-lin merged 1 commit intoNixOS:masterfrom
DamienCassou:fix-emacsPackages-aio-compilation
Jan 2, 2025
Merged

emacs30.pkgs.aio: Fix build#370021
jian-lin merged 1 commit intoNixOS:masterfrom
DamienCassou:fix-emacsPackages-aio-compilation

Conversation

@DamienCassou
Copy link
Contributor

@DamienCassou DamienCassou commented Jan 1, 2025


Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: emacs Text editor label Jan 1, 2025
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Jan 1, 2025
@DamienCassou
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370021


x86_64-linux

✅ 10 packages built:
  • emacsPackages.aio
  • emacsPackages.docker
  • emacsPackages.elfeed-tube
  • emacsPackages.elfeed-tube-mpv
  • emacsPackages.gsnip
  • emacsPackages.leetcode
  • emacsPackages.oauth2-auto
  • emacsPackages.org-gcal
  • emacsPackages.paimon
  • emacsPackages.xenops

Comment on lines 149 to 150
Copy link
Contributor

@jian-lin jian-lin Jan 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment does not bring more information.

If the error is not nix-specific, please report it to upstream with a reproducing example without nix. Then put the issue link in the comment or add a patch.


non-blocking: At the end of this file, there are a large number of overrides for native compilation stuff and they are sorted line by line. I would put this new entry there.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the error is not nix-specific, please report it to upstream with a reproducing example without nix. Then put the issue link in the comment or add a patch.

good idea, done

I would put this new entry there.

I hopefully put the file where you suggested. Please tell me if not.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for upstream a bit. Maybe there is an easy patch we can add instead.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me. The last commit was 5 years ago so I don't have much hope.

Copy link
Contributor

@jian-lin jian-lin Jan 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The author is quite active (for other projects at least).

@DamienCassou DamienCassou force-pushed the fix-emacsPackages-aio-compilation branch from b5e61c3 to c309e66 Compare January 1, 2025 19:59
@DamienCassou DamienCassou requested a review from jian-lin January 1, 2025 20:02
@DamienCassou
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370021


x86_64-linux

✅ 10 packages built:
  • emacsPackages.aio
  • emacsPackages.docker
  • emacsPackages.elfeed-tube
  • emacsPackages.elfeed-tube-mpv
  • emacsPackages.gsnip
  • emacsPackages.leetcode
  • emacsPackages.oauth2-auto
  • emacsPackages.org-gcal
  • emacsPackages.paimon
  • emacsPackages.xenops

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Jan 2, 2025
@jian-lin jian-lin merged commit 0cd3dac into NixOS:master Jan 2, 2025
22 checks passed
@nixpkgs-ci
Copy link
Contributor

nixpkgs-ci bot commented Jan 6, 2025

Successfully created backport PR for release-24.11:

@DamienCassou DamienCassou deleted the fix-emacsPackages-aio-compilation branch April 1, 2025 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: emacs Text editor 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants