spotube: unify linux and darwin builder#369695
Merged
GaetanLepage merged 1 commit intoNixOS:masterfrom Jan 1, 2025
Merged
Conversation
github-actions
bot
added
10.rebuild-darwin: 1-10
Contributor
|
GaetanLepage
reviewed
Jan 1, 2025
pkgs/by-name/sp/spotube/package.nix
Outdated
Contributor
There was a problem hiding this comment.
passthru should be at the bottom, right before meta.
Contributor
Author
There was a problem hiding this comment.
IMO in this case passthru is a bit more important than in other cases, so it doesn't hurt if it's earlier in the file.
Though, I don't care that much about it so I'll change it.
Contributor
There was a problem hiding this comment.
IMO in this case
passthruis a bit more important than in other cases, so it doesn't hurt if it's earlier in the file.Though, I don't care that much about it so I'll change it.
True, both ways would have worked indeed. Thanks for changing though :)
GaetanLepage
approved these changes
Jan 1, 2025
Contributor
GaetanLepage
left a comment
GaetanLepage
left a comment
There was a problem hiding this comment.
LGTM ! Thanks for cleaning things up :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Luckily the github diff is not too horrible
Other then the combining of the two builders I did the following:
finalAttrsmeta.platformsfrompassthru.sourcesThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.