fetchgit{,hub,lab}: passthru rev based on tag#369506
Merged
Atemu merged 3 commits intoNixOS:masterfrom Jan 1, 2025
Merged
Conversation
github-actions
bot
added
the
6.topic: fetch
13 tasks
github-actions
bot
added
10.rebuild-darwin: 0
Atemu
approved these changes
Dec 31, 2024
Member
Atemu
left a comment
Atemu
left a comment
There was a problem hiding this comment.
Nobody should depend on this for any load-bearing code IMHO but it doesn't hurt to expose it like this I guess.
I had a glance at the diff and it LGTM.
Member
Author
|
If we want to stop using |
philiptaron
approved these changes
Dec 31, 2024
Member
|
I'm not sure removing it outright would be the best move but I wouldn't mind. |
wegank
added
the
12.approvals: 2
Member
Author
|
Then i leave the merge decision to the committers who are subscribed |
Contributor
|
Successfully created backport PR for |
1 task
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #355973 (comment)
will enable a lot more migrations in #368177 (comment)
I tested the changed behavior on
evemu.src,snoop.srcandkazumi.srcin the repl.funnily enough this was already the case in
fetchgit, but it did notpassthruthetag. This PR should unify the interfacesThings done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.