Skip to content

boost187: don’t apply NumPy 2 backport patch#369380

Merged
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-quppmqzxptyt
Dec 30, 2024
Merged

boost187: don’t apply NumPy 2 backport patch#369380
emilazy merged 1 commit intoNixOS:masterfrom
emilazy:push-quppmqzxptyt

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Dec 30, 2024

Fixes a conflict between #365042 and the staging-next cycle that finished before it was merged.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested review from afh and tobim December 30, 2024 12:32
@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 30, 2024
@paparodeo
Copy link
Contributor

@ofborg build boost187

@emilazy emilazy merged commit fe1d69e into NixOS:master Dec 30, 2024
24 of 25 checks passed
@emilazy emilazy deleted the push-quppmqzxptyt branch December 30, 2024 15:42
@afh
Copy link
Member

afh commented Dec 30, 2024

Thanks for catching and already addressing this @emilazy, much appreciated 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants