Skip to content

[24.11] hwdata: 0.388 -> 0.390#369230

Merged
wolfgangwalther merged 2 commits intoNixOS:staging-24.11from
dyfrgi:backport-hwdata-0.390
Jan 2, 2025
Merged

[24.11] hwdata: 0.388 -> 0.390#369230
wolfgangwalther merged 2 commits intoNixOS:staging-24.11from
dyfrgi:backport-hwdata-0.390

Conversation

@dyfrgi
Copy link
Contributor

@dyfrgi dyfrgi commented Dec 29, 2024

Changes: vcrhonek/hwdata@v0.388...v0.390

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Dec 29, 2024
@NixOSInfra NixOSInfra added the 12.first-time contribution This PR is the author's first one; please be gentle! label Dec 29, 2024
@ofborg ofborg bot requested a review from PedroHLC December 30, 2024 04:36
@ofborg ofborg bot added 10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. and removed 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. labels Dec 30, 2024
@wolfgangwalther
Copy link
Contributor

wolfgangwalther commented Jan 1, 2025

Seems like this should target staging-24.11 due to the number of rebuilds?

@dyfrgi dyfrgi changed the base branch from release-24.11 to staging-24.11 January 1, 2025 22:02
@dyfrgi
Copy link
Contributor Author

dyfrgi commented Jan 1, 2025

Seems like this should target staging-24.11 due to the number of rebuilds?

Thanks for the tip. This is my first PR to this repo, so I'm following the instructions from https://github.com/NixOS/nixpkgs/blob/master/CONTRIBUTING.md#manually-backporting-changes which say to use release-YY.MM. Reading again now, I see that further down there's some description of the staging- branches. I'll retarget this PR.

@dyfrgi
Copy link
Contributor Author

dyfrgi commented Jan 2, 2025

I'll be away starting tomorrow, January 3, without easy access to GitHub, until January 17. This can remain unmerged until then, or if approved, someone else can merge it. I just backported it so that lspci would list hardware names on my Framework 16, and to make a first contribution to nixpkgs, so there's no hurry on my account.

@wolfgangwalther wolfgangwalther merged commit 1c1a467 into NixOS:staging-24.11 Jan 2, 2025
32 of 33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PedroHLC PedroHLC Awaiting requested review from PedroHLC

Assignees

No one assigned

Labels

10.rebuild-darwin: 101-500 This PR causes between 101 and 500 packages to rebuild on Darwin. 10.rebuild-linux: 501+ This PR causes many rebuilds on Linux and should normally target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. 12.first-time contribution This PR is the author's first one; please be gentle!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dyfrgi @wolfgangwalther @NixOSInfra @trofi