actions/no-channel-pr: re run when base branch is updated#369179
Merged
infinisil merged 1 commit intoNixOS:masterfrom Jan 3, 2025
Merged
actions/no-channel-pr: re run when base branch is updated#369179infinisil merged 1 commit intoNixOS:masterfrom
infinisil merged 1 commit intoNixOS:masterfrom
Conversation
Additionally, no permissions are needed so set it to an empty set Signed-off-by: John Titor <[email protected]>
github-actions
bot
added
6.topic: policy discussion
nix-owners
bot
requested review from
LeSuisse,
azuwis,
mweinelt,
risicle and
zowoq
Member
|
I am not sure this will work. Wouldn't it just re-run the action and fail again? |
github-actions
bot
added
10.rebuild-darwin: 0
Member
|
In #369170, I tried adding some conditionals around |
Member
Author
|
Nope, A manual re run is where some things are cached. This is an automatic re run, just like when actions are ran on a force push. |
Member
|
So, Github will:
In that case it should work. I am not familiar enough with GHA to say whether these steps are accurate however. |
Member
Author
|
Yep, on edited action it will restart the workflow on an entirely new set of variables, which is not the same as restarting a failed job. |
Member
Author
|
@ofborg eval |
Contributor
|
Backported in #370709. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additionally, no permissions are needed so set it to an empty set
Signed-off-by: John Titor [email protected]
Fixes a bug with this action reported in #355847 (comment)