.github/workflows/no-channel.yml: fix re-runs failing incorrectly#369170
Closed
FliegendeWurst wants to merge 1 commit intoNixOS:masterfrom
Closed
.github/workflows/no-channel.yml: fix re-runs failing incorrectly#369170FliegendeWurst wants to merge 1 commit intoNixOS:masterfrom
FliegendeWurst wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: policy discussion
nix-owners
bot
requested review from
LeSuisse,
Mic92,
azuwis,
infinisil,
mweinelt,
risicle and
zowoq
FliegendeWurst
force-pushed
the
no-channel
branch
from
37c2f08 to
f7a887f
Compare
github-actions
bot
added
10.rebuild-darwin: 0
Member
Author
|
It seems this is not enough, for some reason. I checked that it uses the updated workflow file, but the "base_ref" passed around must still be cached.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This action always fails after fixing the base branch. Make it fail only conditionally. (I am not sure a plain PR like this will exercise the fix)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.