Skip to content

boost: boost186 -> boost187#369118

Merged
emilazy merged 1 commit intoNixOS:stagingfrom
emilazy:push-znupztwyzrxt
Jan 5, 2025
Merged

boost: boost186 -> boost187#369118
emilazy merged 1 commit intoNixOS:stagingfrom
emilazy:push-znupztwyzrxt

Conversation

@emilazy
Copy link
Member

@emilazy emilazy commented Dec 29, 2024

It’s early in the NixOS release cycle and the breaking changes don’t seem too bad; might as well get early warning of any issues and perhaps send some patches upstream.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@emilazy emilazy requested a review from tobim December 29, 2024 13:21
@emilazy
Copy link
Member Author

emilazy commented Dec 30, 2024

#369380 fixes the build.

@emilazy emilazy force-pushed the push-znupztwyzrxt branch from a043098 to 8a80b63 Compare January 1, 2025 15:10
@emilazy
Copy link
Member Author

emilazy commented Jan 1, 2025

Rebased for the build fix.

@github-actions github-actions bot added 10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches. labels Jan 1, 2025
@emilazy
Copy link
Member Author

emilazy commented Jan 5, 2025

@tobim The next staging-next is imminent, do you think this is worth trying? I’ve seen some projects patch for Boost 1.87 already and it seems like the substantive breaking changes are restricted to a couple libraries so I’m hopeful it won’t be too painful.

(But of course we could wait untlil the Python split is done and do both in one cycle as well.)

@tobim
Copy link
Contributor

tobim commented Jan 5, 2025

While I'd like to have the latest version as the default, I don't think working on the related fixups for this bump can be a priority for me at the moment.

That said, don't let me or the boost_python split hold you back if you want to go for it.

@emilazy
Copy link
Member Author

emilazy commented Jan 5, 2025

No worries – just wanted to check in case you thought the ecosystem definitely wouldn’t be ready for it. I’m happy to coordinate bumping boost186 back where necessary if all else fails, so I’ll give it a go :)

@emilazy emilazy merged commit 43a7c9b into NixOS:staging Jan 5, 2025
21 checks passed
@emilazy emilazy deleted the push-znupztwyzrxt branch January 5, 2025 14:01
@trofi
Copy link
Contributor

trofi commented Jan 6, 2025

Bisect says 8a80b63 boost: boost186 -> boost187 broke kea build in staging as:

$ nix build --no-link -f. -L kea
...
kea> In file included from io_endpoint.cc:12:
kea> ../../../src/lib/asiolink/tcp_endpoint.h: In constructor 'isc::asiolink::TCPEndpoint::TCPEndpoint(const isc::asiolink::IOAddress&, short unsigned int)':
kea> ../../../src/lib/asiolink/tcp_endpoint.h:45:74: error: 'from_string' is not a member of 'boost::asio::ip::address'
kea>    45 |             new boost::asio::ip::tcp::endpoint(boost::asio::ip::address::from_string(address.toText()),
kea>       |                                                                          ^~~~~~~~~~~

@emilazy
Copy link
Member Author

emilazy commented Jan 6, 2025

Thanks! I can’t find any upstream fix or distro patches (we’re tracking ahead of other distros for once), so it’ll probably need pinning for now unless the fix is super simple. I’ll try to look at it in the next couple of days (but feel free to ping me if I forget, or just pin it to boost186).

@trofi
Copy link
Contributor

trofi commented Jan 20, 2025

wesnoth fails to build against boost187 in master. Proposed the pin as:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 5001+ This PR causes many rebuilds on Darwin and must target the staging branches. 10.rebuild-linux: 5001+ This PR causes many rebuilds on Linux and must target the staging branches.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants