nixos/nixpkgs: merge lists inside config#368051
Closed
SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
Closed
nixos/nixpkgs: merge lists inside config#368051SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
SuperSandro2000 wants to merge 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: nixos
eg permittedInsecurePackages
SuperSandro2000
force-pushed
the
356739
branch
from
cc049ff to
9f28eb6
Compare
github-actions
bot
added
10.rebuild-darwin: 0
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Member
|
It's entirely unclear of how this code works or how this fixes the issue. Please explain and/or refactor. |
nixpkgs-ci
bot
added
9.needs: reviewer
|
Hey! On my road to find a solution to the current situation I stumbled over PR #396595 and this issue … |
nixpkgs-ci
bot
removed
the
2.status: stale
Contributor
|
@SuperSandro2000 I did try to write some unit tests for this functionality and found it surprisingly hard. I would love for us to combine efforts and I do not really care what the resulting attribute is called. |
nixpkgs-ci
bot
added
the
2.status: merge conflict
13 tasks
Member
|
This would also be fixed by #489889 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eg permittedInsecurePackages
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.