Skip to content

wesnoth: pin to boost183 to restore the build#367957

Merged
philiptaron merged 1 commit intoNixOS:masterfrom
trofi:wesnoth-fix-boost-failure
Dec 24, 2024
Merged

wesnoth: pin to boost183 to restore the build#367957
philiptaron merged 1 commit intoNixOS:masterfrom
trofi:wesnoth-fix-boost-failure

Conversation

@trofi
Copy link
Contributor

@trofi trofi commented Dec 24, 2024

Without the change wesnoth fails on master as
https://hydra.nixos.org/build/282695639/nixlog/1:

/build/source/src/server/common/server_base.cpp:84:27: error: call of overloaded 'spawn(boost::asio::io_service&, server_base::start_server()::<lambda(boost::asio::yield_context)>)' is ambiguous

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Without the change `wesnoth` fails on `master` as
https://hydra.nixos.org/build/282695639/nixlog/1:

    /build/source/src/server/common/server_base.cpp:84:27: error: call of overloaded 'spawn(boost::asio::io_service&, server_base::start_server()::<lambda(boost::asio::yield_context)>)' is ambiguous
@trofi trofi mentioned this pull request Dec 24, 2024
13 tasks
@trofi
Copy link
Contributor Author

trofi commented Dec 24, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367957


x86_64-linux

✅ 1 package built:
  • wesnoth

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants