Skip to content

[staging-next] Cherry pick GCC 14 workarounds from haskell-updates#367364

Merged
vcunat merged 5 commits intoNixOS:staging-nextfrom
sternenseemann:haskell-gcc14
Dec 23, 2024
Merged

[staging-next] Cherry pick GCC 14 workarounds from haskell-updates#367364
vcunat merged 5 commits intoNixOS:staging-nextfrom
sternenseemann:haskell-gcc14

Conversation

@sternenseemann
Copy link
Member

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 6.topic: haskell General-purpose, statically typed, purely functional programming language label Dec 22, 2024
@nix-owners nix-owners bot requested a review from maralorn December 22, 2024 12:54
This is another gcc 14 workaround.

haskellPackages.HsOpenSSL: don't silence incompatible-pointer-types

Disabling the error is a better option than silencing the warning which
still applies…

(cherry picked from commit 9c57706)
Work around gcc 14 making implicit-function-declaration an error.

(cherry picked from commit fb7fe3b)
I've contacted the maintainer of libxml-sax directly as the package does
not seem to have a public issue tracker.

(cherry picked from commit 1ad0cb4)
@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 22, 2024
@vcunat vcunat merged commit c5503d2 into NixOS:staging-next Dec 23, 2024
4 of 5 checks passed
@sternenseemann sternenseemann deleted the haskell-gcc14 branch December 23, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: haskell General-purpose, statically typed, purely functional programming language 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants