[staging-next] microsoft-gsl: don't use -Werror for clang#367310
Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom Dec 23, 2024
paparodeo:gsl-no-werror
Merged
[staging-next] microsoft-gsl: don't use -Werror for clang#367310vcunat merged 1 commit intoNixOS:staging-nextfrom paparodeo:gsl-no-werror
vcunat merged 1 commit intoNixOS:staging-nextfrom
paparodeo:gsl-no-werror
Conversation
too many warnings
Contributor
Author
|
rebuild count: {
"darwin": 44,
"linux": 0
} |
ofborg
bot
added
10.rebuild-darwin: 11-100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://hydra.nixos.org/build/281964532
filed upstream issue microsoft/GSL#1178 but for version 4.1.0 -- issue is gtest and c++14 (and -Werror) and they use an older gtest that still maintains c++14 support
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.