Skip to content

[staging-next] superlu: fix darwin#367110

Merged
vcunat merged 1 commit intoNixOS:staging-nextfrom
paparodeo:superlu-no-accelerate
Dec 23, 2024
Merged

[staging-next] superlu: fix darwin#367110
vcunat merged 1 commit intoNixOS:staging-nextfrom
paparodeo:superlu-no-accelerate

Conversation

@paparodeo
Copy link
Contributor

@paparodeo paparodeo commented Dec 21, 2024

workaround xiaoyeli/superlu#155

The update from 5.2.1 -> 7.0.0 causes superlu to segfault running the tests when linked with Accelerate. Set the Blas vendor to Generic to prevent cmake from using Accelerate and use the nixpkgs provided blas/lapack libraries.

https://hydra.nixos.org/build/282035265
#359050

we've seen this before with qrupdate as well c7a88d1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 21, 2024
The update from 5.2.1 -> 7.0.0 causes superlu segfaults running the
tests when linked with Accelerate due to superlu using the single
precision interface.  Set the Blas vendor to Generic to prevent cmake
from using Accelerate and use the nixpkgs provided blas/lapack
libraries.
@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Dec 21, 2024
@paparodeo paparodeo mentioned this pull request Dec 22, 2024
13 tasks
@vcunat vcunat merged commit 798b917 into NixOS:staging-next Dec 23, 2024
4 of 5 checks passed
@paparodeo paparodeo deleted the superlu-no-accelerate branch December 23, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 This PR causes between 11 and 100 packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants