llvmPackages.clang: Drop failing substituteInPlace for CompletionModel.cmake#367056
Merged
alyssais merged 1 commit intoNixOS:stagingfrom Dec 22, 2024
Merged
llvmPackages.clang: Drop failing substituteInPlace for CompletionModel.cmake#367056alyssais merged 1 commit intoNixOS:stagingfrom
alyssais merged 1 commit intoNixOS:stagingfrom
Conversation
…l.cmake Fix up NixOS#356120 for clang 12. The failing replacement target was removed between llvm 12.0.0 and 12.0.1. Ref: NixOS#348568 (comment) Ref: llvm/llvm-project@3be5dbb Signed-off-by: Peter Waller <[email protected]>
github-actions
bot
added
the
6.topic: llvm/clang
This was referenced Dec 21, 2024
nix-owners
bot
requested review from
Ericson2314,
RossComputerGuy,
alyssais,
dtzWill,
lovek323,
rrbutani and
sternenseemann
ofborg
bot
added
10.rebuild-darwin: 11-100
Contributor
Author
|
Can't go to master, depends on https://nixpk.gs/pr-tracker.html?pr=356120 which is only in staging currently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix up #356120 for clang 12. The failing replacement target was removed
between llvm 12.0.0 and 12.0.1.
Ref: #348568 (comment)
Ref: llvm/llvm-project@3be5dbb
Signed-off-by: Peter Waller [email protected]
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.