Skip to content

[staging-next] mozc: use our protobuf (GCC 14 fix)#366868

Merged
vcunat merged 2 commits intoNixOS:staging-nextfrom
FliegendeWurst:mozc-fix
Dec 23, 2024
Merged

[staging-next] mozc: use our protobuf (GCC 14 fix)#366868
vcunat merged 2 commits intoNixOS:staging-nextfrom
FliegendeWurst:mozc-fix

Conversation

@FliegendeWurst
Copy link
Member

This also fixes the build for GCC 14.

Things done

This also fixes the build for GCC 14.
@FliegendeWurst FliegendeWurst changed the title [staging-next] mozc: devendor protobuf (GCC 14 fix) [staging-next] mozc: use our protobuf (GCC 14 fix) Dec 20, 2024
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. labels Dec 20, 2024
@ofborg ofborg bot requested review from gebner and pineapplehunter December 21, 2024 03:55
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 21, 2024
@pineapplehunter
Copy link
Contributor

I think this patch should be applied to pkgs/by-name/fc/fcitx5-mozc/package.nix too.

@FliegendeWurst
Copy link
Member Author

Yes, I caught that soon after this PR but forgot to push it. I'll add it here soon

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. and removed 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. labels Dec 21, 2024
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 21, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. labels Dec 21, 2024
@vcunat vcunat merged commit de59a61 into NixOS:staging-next Dec 23, 2024
4 of 5 checks passed
scarlet-storm added a commit to scarlet-storm/flake that referenced this pull request Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 11-100 This PR causes between 11 and 100 packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants