replaceVars is not needed on setup.sh since 15103e5e5#366611
Merged
wolfgangwalther merged 2 commits intomasterfrom Dec 19, 2024
Merged
replaceVars is not needed on setup.sh since 15103e5e5#366611wolfgangwalther merged 2 commits intomasterfrom
wolfgangwalther merged 2 commits intomasterfrom
Conversation
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
philiptaron
approved these changes
Dec 19, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
A decade of dead code.
Contributor
Author
|
Thank you for this very prompt review and merge @wolfgangwalther and @philiptaron! Looking forward to see this on the unstable channel soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the change in ebd18cf on Dec 14,
myEnvFunno longer evaluates becausereplaceVarsis more strict about attempting to replace variables that do not exist in the source file.This PR removes the replacement of a variable that hasn't existed in
setup.shsince 2014 (in 15103e5).