llvmPackages: remove _IMPORT_PREFIX replacements for clang#366029
Merged
philiptaron merged 1 commit intoNixOS:stagingfrom Dec 18, 2024
Merged
llvmPackages: remove _IMPORT_PREFIX replacements for clang#366029philiptaron merged 1 commit intoNixOS:stagingfrom
_IMPORT_PREFIX replacements for clang#366029philiptaron merged 1 commit intoNixOS:stagingfrom
Conversation
These strings do not show up in the files where they are attempting to be replaced.
github-actions
bot
added
the
6.topic: llvm/clang
13 tasks
nix-owners
bot
requested review from
Ericson2314,
alyssais,
dtzWill,
lovek323,
rrbutani and
sternenseemann
Contributor
Author
|
This PR doesn't introduce that error, but it doesn't fix it either. |
paparodeo
approved these changes
Dec 18, 2024
Contributor
paparodeo
left a comment
paparodeo
left a comment
There was a problem hiding this comment.
looked at clang-{12,17,18} and the change LGTM
wegank
added
the
12.approvals: 1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These strings do not show up in the files where they are attempting to be replaced.
This fixes the build for
clang_15,clang_16,clang_17,clang_18, andclang_19. The remaining three (clang_12,clang_13, andclang_14) are broken due tollvmPackages_12.tblgen,llvmPackages_13.tblgen, andllvmPackages_14.tblgenerrors.Resolves the issue that @trofi found in #356120.
CC @pwaller
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)