treewide: replace substituteAll with replaceVars (#1)#365440
Merged
philiptaron merged 1 commit intoNixOS:masterfrom Dec 16, 2024
Merged
treewide: replace substituteAll with replaceVars (#1)#365440philiptaron merged 1 commit intoNixOS:masterfrom
philiptaron merged 1 commit intoNixOS:masterfrom
Conversation
github-actions
bot
added
6.topic: qt/kde
Contributor
Author
|
nix-owners
bot
requested review from
AndersonTorres,
K900,
Ma27,
NickCao,
SuperSandro2000,
adisbladis,
jian-lin,
matthewbauer,
thoughtpolice and
ttuegel
Driving NixOS#237216 forward.
wolfgangwalther
force-pushed
the
refactor-tractor-1
branch
from
c115ccc to
ebd18cf
Compare
github-actions
bot
added
10.rebuild-darwin: 11-100
philiptaron
approved these changes
Dec 15, 2024
Contributor
philiptaron
left a comment
philiptaron
left a comment
There was a problem hiding this comment.
The commit message appears to GitHub to be referencing this PR:
And when merged will likely refer to this one:
Contributor
|
Contributor
Author
|
@jwiegley posted a comment directly on the merged commit. For visibility, I reproduce it here:
This relates to Looking at the nixpkgs-review list, this package was indeed not built. Fix in #366611. |
Contributor
Author
|
I went through the builds that failed for other reasons during nixpkgs-review and those that didn't trigger a build at all, e.g. because of conditionals. Confirmed manually that all replacements are available - no other problems found. |
13 tasks
This was referenced Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some more gifts from the refactor tractor.
Driving towards #237216
Those are a sub-set of really simple-to-replace cases. I ran the following script:
but then only selected a smaller part of the changes with the goal of avoiding too many rebuilds, so that this can target master and easily be tested with nixpkgs-review.
Everything that fails to build is left out and will come at the end with more specific fixes.
@philiptaron
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.