windows.mingw_w64_headers: fix building against msvcrt#365060
Merged
misuzu merged 1 commit intoNixOS:masterfrom Dec 14, 2024
Merged
windows.mingw_w64_headers: fix building against msvcrt#365060misuzu merged 1 commit intoNixOS:masterfrom
misuzu merged 1 commit intoNixOS:masterfrom
Conversation
Previously we relied on the default CRT selected by upstream. This broke builds against MSVCRT starting with 12.0, as the default was changed to UCRT We can instead manually configure the CRT based on our `stdenv` to ensure there is no discrepancy between the CRT we want to use and that being targeted by the build
getchoo
added
6.topic: cross-compilation
github-actions
bot
added
10.rebuild-darwin: 1-10
puffnfresh
approved these changes
Dec 14, 2024
getchoo
added
the
12.approvals: 1
greg-hellings
approved these changes
Dec 14, 2024
Contributor
greg-hellings
left a comment
greg-hellings
left a comment
There was a problem hiding this comment.
I can confirm that this solves the problem in #362550
greg-hellings
added
the
12.approvals: 2
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #362550
Looks like I missed this in #335067, as I only tested the update on the UCRT-based aarch64-windows target. Oops!
See commit message for more context
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.