Skip to content

boost187: init at 1.87.0#365042

Merged
emilazy merged 1 commit intoNixOS:masterfrom
afh:init-boost-187
Dec 27, 2024
Merged

boost187: init at 1.87.0#365042
emilazy merged 1 commit intoNixOS:masterfrom
afh:init-boost-187

Conversation

@afh
Copy link
Member

@afh afh commented Dec 13, 2024 •
edited
Loading

Release notes: https://www.boost.org/users/history/version_1_87_0.html

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. labels Dec 13, 2024
@afh
Copy link
Member Author

afh commented Dec 13, 2024

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 365042

x86_64-linux

✅ 2 packages built:
  • boost187
  • boost187.dev

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. labels Dec 14, 2024
@afh afh added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 16, 2024
@emilazy emilazy merged commit 28d78e5 into NixOS:master Dec 27, 2024
4 of 5 checks passed
@emilazy
Copy link
Member

emilazy commented Dec 27, 2024

@tobim Time for another round of staging fun, perhaps?

@afh afh deleted the init-boost-187 branch December 28, 2024 13:00
@afh
Copy link
Member Author

afh commented Dec 28, 2024

Thanks for the review, @tobim, and thanks for merging @emilazy, much appreciated.

@emilazy emilazy mentioned this pull request Dec 30, 2024
Merged
13 tasks
@emilazy
Copy link
Member

emilazy commented Dec 30, 2024

Whoops, this was merged in a broken state that CI didn’t catch because of changes in the staging cycle. Fix is #369380.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tobim tobim tobim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 This PR causes between 1 and 10 packages to rebuild on Darwin. 10.rebuild-darwin: 1 This PR causes 1 package to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-linux: 1 This PR causes 1 package to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@afh @emilazy @tobim