buildLinux: kernel.configEnv: fix overridinig#364679
Merged
alyssais merged 1 commit intoNixOS:masterfrom Dec 18, 2024
Merged
Conversation
Override `finalAttrs.finalPackage` instead of `kernel` from the let-in block to make configEnv behave in accordance with overrideAttrs of the result package. Continuation of commit f10331c ("buildLinux: passthru by <pkg>.overrideAttrs instead of lib.extendDerivation")
Contributor
Author
|
github-actions
bot
added
10.rebuild-darwin: 0
13 tasks
Contributor
Author
|
Contributor
|
Successfully created backport PR for |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement by overriding
finalAttrs.finalPackage(instead ofkernelfrom the let-in block) to updateconfigEnvwhen overriding the kernel package withoverrideAttrs.Leftover of #288154
Cc:
@TredwellGit @Ma27 @NeQuissimus @alyssais @thoughtpolice (
linuxmaintainers)@infinisil (#288154 reviewer)
Things done
linuxandlinux.configEnv. TheirdrvPathremains the same before and after this change.)nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage (no rebuilds)./result/bin/)Add a 👍 reaction to pull requests you find important.