Skip to content

[24.11] fetchFromGitHub: expose tag argument#364439

Merged
Atemu merged 1 commit intoNixOS:release-24.11from
Atemu:backport/fetchgithub-expose-tag
Dec 12, 2024
Merged

[24.11] fetchFromGitHub: expose tag argument#364439
Atemu merged 1 commit intoNixOS:release-24.11from
Atemu:backport/fetchgithub-expose-tag

Conversation

@Atemu
Copy link
Member

@Atemu Atemu commented Dec 12, 2024

(cherry picked from commit ce33e20)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@Atemu Atemu requested a review from dotlambda December 12, 2024 03:11
@github-actions github-actions bot added the 6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) label Dec 12, 2024
@nix-owners nix-owners bot requested a review from philiptaron December 12, 2024 03:12
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 12, 2024
Copy link
Contributor

@philiptaron philiptaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah.

@Atemu Atemu merged commit 9a21d63 into NixOS:release-24.11 Dec 12, 2024
@Atemu Atemu deleted the backport/fetchgithub-expose-tag branch December 12, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: fetch Fetchers (e.g. fetchgit, fetchsvn, ...) 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants