Skip to content

maintainers/team-list: establish the gnome circle team#364181

Merged
Aleksanaa merged 2 commits intoNixOS:masterfrom
getchoo-contrib:maintainers/team-list/gnome-circle
Dec 12, 2024
Merged

maintainers/team-list: establish the gnome circle team#364181
Aleksanaa merged 2 commits intoNixOS:masterfrom
getchoo-contrib:maintainers/team-list/gnome-circle

Conversation

@getchoo
Copy link
Member

@getchoo getchoo commented Dec 11, 2024

Based on the work in #195280, a team dedicated towards GNOME Circle apps will help provide a better experience for the many current and future additons to GNOME's incubator project

CC @NixOS/gnome

It would probably be best to leave this open for a bit to give maintainers of these packages (or anyone else) a chance to join the team as well. I've added myself and @Aleksanaa to begin with

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@getchoo
Copy link
Member Author

getchoo commented Dec 11, 2024

The only apps I've excluded from the treewide commit are gnome-podcasts and polari, as they're already maintained by the GNOME team even though they appear to be circle apps; would it be preferred for both of us to maintain these?

@getchoo getchoo force-pushed the maintainers/team-list/gnome-circle branch 2 times, most recently from 7b900b0 to 2c72d62 Compare December 11, 2024 09:10
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. labels Dec 11, 2024
Copy link
Member

@Aleksanaa Aleksanaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove your and my names from those packages where the gnome-circle team is added, to make the code clean.

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one person. label Dec 11, 2024
@dawidd6
Copy link
Contributor

dawidd6 commented Dec 11, 2024

Nice 👍. You can add me to the team too.

@getchoo getchoo force-pushed the maintainers/team-list/gnome-circle branch from 2c72d62 to 3169a2c Compare December 11, 2024 19:35
@getchoo getchoo requested review from dawidd6 and jtojnar December 11, 2024 19:35
@Aleksanaa Aleksanaa merged commit b65461d into NixOS:master Dec 12, 2024
@getchoo getchoo deleted the maintainers/team-list/gnome-circle branch December 12, 2024 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux. 12.approvals: 1 This PR was reviewed and approved by one person.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants