super-slicer: fix build with GCC 14#362194
Merged
bendlas merged 1 commit intoNixOS:masterfrom Dec 9, 2024
Merged
Conversation
2 tasks
github-actions
bot
added
10.rebuild-darwin: 1-10
Contributor
|
I'm getting a build error, when applying this on latest unstable: ± nix-build . -A super-slicer-latest
this derivation will be built:
/nix/store/47j1v340k32jn3v46bjkzqi9k42xdzlr-super-slicer-2.4.58.5.drv
building '/nix/store/47j1v340k32jn3v46bjkzqi9k42xdzlr-super-slicer-2.4.58.5.drv'...
Running phase: unpackPhase
unpacking source archive /nix/store/vfqwfnc0m23mlndi80amcfagyk3dddrn-source
source root is source
Running phase: patchPhase
substituteStream() in derivation super-slicer-2.4.58.5: WARNING: '--replace' is deprecated, use --replace-{fail,warn,quiet}. (file 'src/PrusaSlicer.cpp')
substituteStream() in derivation super-slicer-2.4.58.5: WARNING: pattern list\(APPEND\ wxWidgets_LIBRARIES\ libexpat\) doesn't match anything in file 'src/CMakeLists.txt'
substituteStream() in derivation super-slicer-2.4.58.5: WARNING: pattern libexpat doesn't match anything in file 'src/libslic3r/CMakeLists.txt'
applying patch /nix/store/a1vdclpnypig8j0n419590qjk9vgqdki-superslicer-2.4.58.3-boost-1.79-port-v2.patch
patching file src/hints/HintsToPot.cpp
patching file src/libslic3r/AppConfig.cpp
patching file src/libslic3r/AppConfig.hpp
patching file src/libslic3r/LocalesUtils.cpp
patching file src/libslic3r/Preset.cpp
patching file src/slic3r/GUI/CreateMMUTiledCanvas.cpp
patching file src/slic3r/GUI/DesktopIntegrationDialog.cpp
patching file src/slic3r/GUI/GUI_App.cpp
patching file src/slic3r/GUI/HintNotification.cpp
patching file src/slic3r/GUI/Preferences.cpp
patching file src/slic3r/GUI/ScriptExecutor.cpp
applying patch /nix/store/xgd5yzxl0ln024327ipsz2kdjmdslcwf-meshboolean-const.patch
patching file src/libslic3r/MeshBoolean.cpp
Hunk #1 FAILED at 147.
1 out of 1 hunk FAILED -- saving rejects to file src/libslic3r/MeshBoolean.cpp.rej
error: builder for '/nix/store/47j1v340k32jn3v46bjkzqi9k42xdzlr-super-slicer-2.4.58.5.drv' failed with exit code 1;
last 23 log lines:
> Running phase: unpackPhase
> unpacking source archive /nix/store/vfqwfnc0m23mlndi80amcfagyk3dddrn-source
> source root is source
> Running phase: patchPhase
> substituteStream() in derivation super-slicer-2.4.58.5: WARNING: '--replace' is deprecated, use --replace-{fail,warn,quiet}. (file 'src/PrusaSlicer.cpp')
> substituteStream() in derivation super-slicer-2.4.58.5: WARNING: pattern list\(APPEND\ wxWidgets_LIBRARIES\ libexpat\) doesn't match anything in file 'src/CMakeLists.txt'
> substituteStream() in derivation super-slicer-2.4.58.5: WARNING: pattern libexpat doesn't match anything in file 'src/libslic3r/CMakeLists.txt'
> applying patch /nix/store/a1vdclpnypig8j0n419590qjk9vgqdki-superslicer-2.4.58.3-boost-1.79-port-v2.patch
> patching file src/hints/HintsToPot.cpp
> patching file src/libslic3r/AppConfig.cpp
> patching file src/libslic3r/AppConfig.hpp
> patching file src/libslic3r/LocalesUtils.cpp
> patching file src/libslic3r/Preset.cpp
> patching file src/slic3r/GUI/CreateMMUTiledCanvas.cpp
> patching file src/slic3r/GUI/DesktopIntegrationDialog.cpp
> patching file src/slic3r/GUI/GUI_App.cpp
> patching file src/slic3r/GUI/HintNotification.cpp
> patching file src/slic3r/GUI/Preferences.cpp
> patching file src/slic3r/GUI/ScriptExecutor.cpp
> applying patch /nix/store/xgd5yzxl0ln024327ipsz2kdjmdslcwf-meshboolean-const.patch
> patching file src/libslic3r/MeshBoolean.cpp
> Hunk #1 FAILED at 147.
> 1 out of 1 hunk FAILED -- saving rejects to file src/libslic3r/MeshBoolean.cpp.rej
For full logs, run 'nix log /nix/store/47j1v340k32jn3v46bjkzqi9k42xdzlr-super-slicer-2.4.58.5.drv'. |
FliegendeWurst
force-pushed
the
super-slicer-fix
branch
from
91eebec to
df753c2
Compare
Member
Author
|
I moved the custom patches to postPatch. |
Aleksanaa
reviewed
Dec 6, 2024
FliegendeWurst
force-pushed
the
super-slicer-fix
branch
from
df753c2 to
4ad5c04
Compare
Contributor
|
Can happily confirm that I've found that the postInstall = ''
mkdir -p "$out/lib"
mv -v $out/bin/*.so $out/lib/
'';I'd submit a PR for this but given the build is currently broken I'll hold off until this PR is merged. |
srounce
approved these changes
Dec 8, 2024
Contributor
srounce
left a comment
srounce
left a comment
There was a problem hiding this comment.
All three attributes (super-slicer, super-slicer-beta, super-slicer-latest) are building and functional again.
Contributor
|
Works. Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continued from #361477
Things done