Skip to content

workflows/eval: add eval summary to commit statuses#361973

Merged
Mic92 merged 1 commit intoNixOS:masterfrom
azuwis:push-qunxukmmvwoo
Dec 5, 2024
Merged

workflows/eval: add eval summary to commit statuses#361973
Mic92 merged 1 commit intoNixOS:masterfrom
azuwis:push-qunxukmmvwoo

Conversation

@azuwis
Copy link
Contributor

@azuwis azuwis commented Dec 5, 2024

See #361388 (comment)

Demo: azuwis#15

Screenshot:

Screenshot 2024-12-05 at 14 30 02

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: policy discussion Discuss policies to work in and around Nixpkgs 6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions labels Dec 5, 2024
@wolfgangwalther
Copy link
Contributor

Love it, exactly the level of visibility and usability we need, imho.

@FliegendeWurst
Copy link
Member

Unfortunately it doesn't really work with the beta "merge experience". You have to click twice, scroll down, and then you don't even see the summary :(
image

@azuwis
Copy link
Contributor Author

azuwis commented Dec 5, 2024

Unfortunately it doesn't really work with the beta "merge experience". You have to click twice, scroll down, and then you don't even see the summary :(

Same for ofborg, that's really a bug of the beta "merge experience" to me:

Screenshot 2024-12-05 at 17 18 57

We should give feedback here.

@azuwis
Copy link
Contributor Author

azuwis commented Dec 5, 2024

@Mic92 Mic92 merged commit c853ed5 into NixOS:master Dec 5, 2024
@azuwis azuwis deleted the push-qunxukmmvwoo branch December 6, 2024 02:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: policy discussion Discuss policies to work in and around Nixpkgs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants